Attention is currently required from: Nico Huber, Paul Menzel, SH Kim, Julius Werner, Yu-Ping Wu, Karthik Ramasubramanian.
shkim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57327 )
Change subject: lib/edid_fill_fb: Make framebuffer orientation to be configurable
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS2:
I agree the existing API was better. I think we can have two mechanisms […]
Okay guys. I don't have DUT in my hand now, I'll try and verify your suggestion in a few days.. Thanks.
- Adding lb_get_first_framebuffer() into lib/edid_fill_fb.c
- Adding adjusting orientation in mainboard_dev->final() using lb_get_first_framebuffer()
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57327
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ice7f7ab66e40d19c76fbf5876e7d4d3e3b2088fa
Gerrit-Change-Number: 57327
Gerrit-PatchSet: 4
Gerrit-Owner: shkim
sh_.kim@samsung.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 06 Sep 2021 01:49:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: shkim
sh_.kim@samsung.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment