Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32719 )
Change subject: drivers/apple: Add hybrid graphics driver ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/#/c/32719/7/src/drivers/apple/hybrid_graphics/hy... File src/drivers/apple/hybrid_graphics/hybrid_graphics.c:
https://review.coreboot.org/#/c/32719/7/src/drivers/apple/hybrid_graphics/hy... PS7, Line 35: config = dev->chip_info; config isn't used
https://review.coreboot.org/#/c/32719/7/src/drivers/apple/hybrid_graphics/ro... File src/drivers/apple/hybrid_graphics/romstage.c:
https://review.coreboot.org/#/c/32719/7/src/drivers/apple/hybrid_graphics/ro... PS7, Line 42: config = dev->chip_info; config isn't used