[coreboot-gerrit] [S] Change in coreboot[master]: cbfstool/default-x86.fmd: Rename BIOS -> SI_BIOS

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73449 )

Change subject: cbfstool/default-x86.fmd: Rename BIOS -> SI_BIOS
......................................................................

Patch Set 6:

(1 comment)

Patchset:

PS6:
> > Is this a good idea? The SI prefix seems to be applied to mostly Intel boards. […]

I think generally using the coreboot build-system as a general stitching/verfication
tool for out-of-scope, proprietary components is not a good idea. In this particular
case, I assume both the IFD and the correct CBFS_SIZE setting come from outside the
coreboot repository. So it might be better to validate them there? Doesn't mean
ifdtool couldn't be extended to validate whatever is necessary, e.g. in this case
having an option to specify the region name to assume as matching IFD/BIOS would
be one way.