[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Add Whiskeylake SoC kconfig

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31133 )

Change subject: soc/intel/cannonlake: Add Whiskeylake SoC kconfig
......................................................................

Patch Set 7:

(2 comments)

https://review.coreboot.org/#/c/31133/7/src/soc/intel/cannonlake/Kconfig 
File src/soc/intel/cannonlake/Kconfig:

https://review.coreboot.org/#/c/31133/7/src/soc/intel/cannonlake/Kconfig@14 
PS7, Line 14: and SOC_INTEL_CANNONLAKE Kconfig are in FSP Header Files. Hence this Kconfig
            : 	  might help to select required SoC support FSP headers. Any future Intel SoC would
Are these lines too long?

https://review.coreboot.org/#/c/31133/7/src/soc/intel/cannonlake/Kconfig@266 
PS7, Line 266: 3rdparty/fsp/CoffeeLakeFspBinPkg/Include/
Have to be careful about this. If SOC_INTEL_COMMON_CANNONLAKE_BASE is expected to be selected by all new SoCs using CNL PCH, then you need to ensure that they use the right FSP headers and paths.