[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Set correct serirq mode based on SERIRQ_CONTINU...

[Jeremy Soller (Code Review)]

Jeremy Soller has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31536 )

Change subject: soc/intel/cannonlake: Set correct serirq mode based on SERIRQ_CONTINUOUS_MODE
......................................................................

Patch Set 2:
> Patch Set 2: Code-Review+1
>
> (1 comment)
>
> Thanks for the fix. I wouldn't mind merging it in this
> state, though maybe see if we can settle on the Kconfig
> vs `chip.h` thing, first.
>
> NB. There may be more unset UPDs related to serial irqs.
> Maybe we should set them all at once.

The issue is that the FSP-S will set the Sirq mode to quiet no matter what. This is not overwritten because without the change I made to KConfig, there is no way to set continuous mode in coreboot after FSP-S.