Attention is currently required from: Bora Guvendik, Anil Kumar K, Selma Bensaid, Tim Wawrzynczak, Bernardo Perez Priego.
Hsuan-ting Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58099 )
Change subject: mb/adlrvp: Add hook function to return EC in RW status
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/intel/adlrvp/chromeos.c:
https://review.coreboot.org/c/coreboot/+/58099/comment/93358ca3_bad55eda
PS4, Line 50: int get_ec_is_trusted(void)
: {
: /* EC is trusted if not in RW. */
: return !gpio_get(GPIO_EC_IN_RW);
: }
There is nothing left in depthcharge to handle that "EC in RW" gpios.
(removed at: https://chromium-review.googlesource.com/c/chromiumos/platform/depthcharge/+...)
Now, the equivalent logic is moved to coreboot and handled by this function.
So I think we should guard this function as well. (It will use the default __weak function in src/third_party/coreboot/src/security/vboot/bootmode.c instead, which always returns false)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58099
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I20804db450ab0b3ebe19c51ba2b294a0137d81a7
Gerrit-Change-Number: 58099
Gerrit-PatchSet: 4
Gerrit-Owner: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Hsuan-ting Chen
roccochen@google.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Comment-Date: Tue, 05 Oct 2021 02:18:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment