Attention is currently required from: Paul Menzel, Mario Scheithauer, Lean Sheng Tan, Werner Zeh.
Jan Samek has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74433 )
Change subject: drivers/i2c: Add PI7C9X2G608GP PCIe switch driver (pi608gp)
......................................................................
Patch Set 14:
(1 comment)
File src/drivers/i2c/pi608gp/pi608gp.c:
https://review.coreboot.org/c/coreboot/+/74433/comment/33d649bf_ffa34c7d
PS12, Line 71: /* Compose the SMBus message for register read init operation (from MSB to LSB):
: Byte 1: 7:3 = Rsvd., 2:0 = Command,
: Byte 2: 7:4 = Rsvd., 3:0 = Port Select[4:1],
: Byte 3: 7 = Port Select[0], 6 = Rsvd., 5:2 = Byte Enable, 1:0 = Reg. Addr. [11:10],
: Byte 4: 7:0 = Reg. Addr.[9:2] (Reg. Addr. [1:0] fixed to 0). */
I’d use: […]
OK, now it's clear - thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74433
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id191c4e97b99da58efd3ba38bf8cca3603ece4d5
Gerrit-Change-Number: 74433
Gerrit-PatchSet: 14
Gerrit-Owner: Jan Samek
jan.samek@siemens.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Wed, 26 Apr 2023 09:54:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Jan Samek
jan.samek@siemens.com
Gerrit-MessageType: comment