Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31249 )
Change subject: soc/intel/denverton_ns: Don't use CONFIG_CBFS_SIZE
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/31249/1/src/soc/intel/denverton_ns/bootblock...
File src/soc/intel/denverton_ns/bootblock/bootblock.c:
https://review.coreboot.org/#/c/31249/1/src/soc/intel/denverton_ns/bootblock...
PS1, Line 41: .CodeRegionLength = (UINT32)CONFIG_ROM_SIZE,
How about CACHE_ROM_BASE/_SIZE? unless we trust FSP to
always align correctly.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31249
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iae72a9fb02d62d7548d34689f5eb371f34cd3d81
Gerrit-Change-Number: 31249
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Guckian
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Vanny E
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 28 May 2019 08:07:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment