Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47191 )
Change subject: mb/purism/librem_mini: Set unused GPIO pads to PAD_NC ......................................................................
Patch Set 2: Code-Review+1
(4 comments)
https://review.coreboot.org/c/coreboot/+/47191/2/src/mainboard/purism/librem... File src/mainboard/purism/librem_cnl/variants/librem_mini/gpio.c:
https://review.coreboot.org/c/coreboot/+/47191/2/src/mainboard/purism/librem... PS2, Line 84: /* GPP_B0 - Reserved */ : PAD_NC(GPP_B0, NONE), : : /* GPP_B1 - Reserved */ : PAD_NC(GPP_B1, NONE), Looking again, these two should have a pull, or can be left as native functions.
https://review.coreboot.org/c/coreboot/+/47191/2/src/mainboard/purism/librem... PS2, Line 223: /* GPP_D13 - GPIO */ : PAD_NC(GPP_D13, NONE), : : /* GPP_D14 - GPIO */ : PAD_CFG_GPO(GPP_D14, 1, PLTRST), Both of these are unused, and should have a pull (down, 20k)
https://review.coreboot.org/c/coreboot/+/47191/2/src/mainboard/purism/librem... PS2, Line 350: /* GPP_H6 - I2C3_SDA */ : PAD_NC(GPP_H6, NONE), : : /* GPP_H7 - I2C3_SCL */ : PAD_NC(GPP_H7, NONE), : : /* GPP_H8 - I2C4_SDA */ : PAD_NC(GPP_H8, NONE), : : /* GPP_H9 - I2C4_SCL */ : PAD_NC(GPP_H9, NONE), These are floating and should use a pull (up, 20k).
https://review.coreboot.org/c/coreboot/+/47191/2/src/mainboard/purism/librem... PS2, Line 368: /* GPP_H12 - GPIO */ : PAD_CFG_GPO(GPP_H12, 1, PLTRST), : : /* GPP_H13 - GPIO */ : PAD_CFG_GPO(GPP_H13, 1, PLTRST), : : /* GPP_H14 - GPIO */ : PAD_NC(GPP_H14, NONE), : : /* GPP_H15 - GPIO */ : PAD_CFG_GPO(GPP_H15, 1, PLTRST), : : /* GPP_H16 - GPIO */ : PAD_NC(GPP_H16, NONE), : : /* GPP_H17 - GPIO */ : PAD_NC(GPP_H17, NONE), These are floating and should use a pull (up, 20k).