Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42821 )
Change subject: soc/intel/tigerlake: Add platform wide _OSC capabilities for USB4 ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42821/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42821/3//COMMIT_MSG@16 PS3, Line 16: This change also fixes the byte index : for the DWord-addressable field CDW3 from the capabilities buffer Sorry about that, I think that was my fault; I misremembered how DWordField counted indexes.
https://review.coreboot.org/c/coreboot/+/42821/3/src/soc/intel/tigerlake/acp... File src/soc/intel/tigerlake/acpi/tcss.asl:
https://review.coreboot.org/c/coreboot/+/42821/3/src/soc/intel/tigerlake/acp... PS3, Line 180: Name (CTRL, 0) /* Control field value */ : CreateDWordField (Arg3, 8, CDW3) : CTRL = CDW3 : : If (Arg1 != REVISION_ID) { : CDW1 |= UNRECOGNIZED_REVISION : Return (Arg3) : } : CTRL |= USB_TUNNELING | DISPLAY_PORT_TUNNELING | PCIE_TUNNELING | : INTER_DOMAIN_USB4_INTERNET_PROTOCOL : CDW3 = CTRL Is there a reason you can't use Local0 instead of CTRL ? Local0 = CDW3, ... Local0 |= USB_TUNNELING ... CDW3 = Local0 etc.?