22 Nov
2023
22 Nov
'23
11:22 a.m.
Attention is currently required from: Srinivas Hegde.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79218?usp=email )
Change subject: src/arch/x86/Makefile.inc: Do not pass CPPFLAGS to linker ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
+Patrick, any idea why this was added in CB:9283?
Uh, that commit has a troubled history. It might be a left-over from some attempt to fix things.
The easiest way to validate that removing it isn't too bad would be to do a full run (`util/abuild/abuild -p none --timeless --cpu $(nproc)` or similar) with and without the patch and see if the coreboot.rom files all remain identical.
--
To view, visit https://review.coreboot.org/c/coreboot/+/79218?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia3cd51be6be252aa796191cf0d2cd91d393c8878
Gerrit-Change-Number: 79218
Gerrit-PatchSet: 2
Gerrit-Owner: Srinivas Hegde srinivashegde@google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Reviewer: Patrick Georgi patrick@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Srinivas Hegde srinivashegde@google.com
Gerrit-Comment-Date: Wed, 22 Nov 2023 10:22:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Gerrit-MessageType: comment