Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31606 )
Change subject: libpayload: cbfs: Require input size and output size for cbfs_decompress
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31606/1/payloads/libpayload/libcbfs/cbfs_cor...
File payloads/libpayload/libcbfs/cbfs_core.c:
https://review.coreboot.org/#/c/31606/1/payloads/libpayload/libcbfs/cbfs_cor...
PS1, Line 331: len = MIN(srcn, dstn);
Pretty sure it does. See this: https://pastebin.com/8Eh1AkSU […]
Ohh... okay, interesting, So maybe it is LZ4 which we should align to the others then? I think if you just change ulz4fn() to always return (out - dst) directly (and adjust out before the break in the output overrun case), that should do it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31606
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe617825bd000ed618791d8e3c5f65bbbd5f7e33
Gerrit-Change-Number: 31606
Gerrit-PatchSet: 2
Gerrit-Owner: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Daisuke Nojiri
dnojiri@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 27 Feb 2019 05:44:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Daisuke Nojiri
dnojiri@chromium.org
Comment-In-Reply-To: You-Cheng Syu
youcheng@google.com
Gerrit-MessageType: comment