Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46391 )
Change subject: mb/google/asurada: Get ram id from AUX_IN3 ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46391/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46391/4//COMMIT_MSG@7 PS4, Line 7: b/google/asurada: Get ram id from AUX_IN3 : : Mapping the voltage of AUX_IN3 to ram id. Maybe change to:
mb/google/asurada: Get RAM code from ADC 3
On Chromebooks the RAM code is implemented by the resistor straps that we can read and decode from ADC. For Asurada the RAM code can be read from ADC channel 3.