Attention is currently required from: Paul Menzel, Angel Pons, Iru Cai.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46630 )
Change subject: mb/hp: Add EliteBook 820 G2 ......................................................................
Patch Set 10:
(8 comments)
File src/mainboard/hp/elitebook_820_g2/Kconfig:
https://review.coreboot.org/c/coreboot/+/46630/comment/6befc864_3a71090f PS9, Line 9: select MAINBOARD_HAS_LIBGFXINIT : select MEMORY_MAPPED_TPM : select MAINBOARD_HAS_TPM1 : select MAINBOARD_USES_IFD_GBE_REGION
to keep the alphabetical order: […]
Done
https://review.coreboot.org/c/coreboot/+/46630/comment/2426813d_49d71186 PS9, Line 17: string
Remove type, already defined elsewhere.
Done
https://review.coreboot.org/c/coreboot/+/46630/comment/15abe9e2_7d7a02db PS9, Line 21: string
Remove type, already defined elsewhere.
Done
https://review.coreboot.org/c/coreboot/+/46630/comment/5dbe9431_165b05a8 PS9, Line 25: string
Remove type, already defined elsewhere.
Done
https://review.coreboot.org/c/coreboot/+/46630/comment/a30ac078_74135b56 PS9, Line 29: bool
Remove type, already defined elsewhere.
Done
https://review.coreboot.org/c/coreboot/+/46630/comment/4b303c64_0868dbdd PS9, Line 33: hex
Remove type, already defined elsewhere.
Done
File src/mainboard/hp/elitebook_820_g2/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/46630/comment/13a34025_dea43f9f PS9, Line 26: register "gen1_dec" = "0x007c0201" : register "gen2_dec" = "0x000c0101" : register "gen4_dec" = "0x000402e9" : register "gpe0_en_1" = "0x40" : register "gpe0_en_2" = "0x600" : register "gpe0_en_4" = "0x46"
Same here. […]
Done
https://review.coreboot.org/c/coreboot/+/46630/comment/025ff3ff_c5d6206d PS9, Line 33: register "sata_port1_gen3_dtle" = "0x2" : register "sata_port1_gen3_tx" = "0x80" : register "sata_port3_gen3_dtle" = "0x4" : register "sata_port3_gen3_tx" = "0x80" : # SATA (1), M.2 (3) : register "sata_port_map" = "0xa"
Please move these into the scope of the SATA controller
Done