Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41571 )
Change subject: soc/intel/tigerlake: Configure THC ......................................................................
Patch Set 7: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/41571/5/src/soc/intel/tigerlake/fsp... File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/41571/5/src/soc/intel/tigerlake/fsp... PS5, Line 235: 2
How about a symbolic constant for this?, something like […]
Done
https://review.coreboot.org/c/coreboot/+/41571/6/src/soc/intel/tigerlake/fsp... File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/41571/6/src/soc/intel/tigerlake/fsp... PS6, Line 20: /* THC assignement definition */
'assignement' may be misspelled - perhaps 'assignment'?
Done