Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42339 )
Change subject: soc/amd/picasso: fix build if PICASSO_UART is unset ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42339/2/src/soc/amd/picasso/uart.c File src/soc/amd/picasso/uart.c:
https://review.coreboot.org/c/coreboot/+/42339/2/src/soc/amd/picasso/uart.c@... PS2, Line 33: PICASSO_UART
Should this be renamed to PICASSO_CONSOLE_UART?
good idea; will do, since this is about the coreboot console
https://review.coreboot.org/c/coreboot/+/42339/2/src/soc/amd/picasso/uart.c@... PS2, Line 59:
There will have to be a check here as well: […]
I don't think so; this function is about setting up the uart hardware and not to configure the console. Also the only call to this is in southbridge.c and it's guarded by a if (CONFIG(PICASSO_UART)). Would also be good to further refactor the uart part, but fixing the newly introduced breakage around mandolin is currently much higher on my priority list.