Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33115 )
Change subject: Makefile.inc: Exclude smm related files from ramstage compilation
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33115/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/33115/1//COMMIT_MSG@7
PS1, Line 7: Makefile.inc: Exclude smm related files from ramstage compilation
If you are you reordering Makefiles then say that. […]
i don't think, its just recording. if you see there is a if(ramstage_config) and endif check, one can deselect ramsatge_config and smm code will not be able to compile
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33115
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I17a3eb80a4d5ef86e0319357c01b6bf5b90ef15b
Gerrit-Change-Number: 33115
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Thu, 30 May 2019 14:39:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment