EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40558 )
Change subject: soc/intel/common/block/smbus: Set SPD array NULL if no DIMM present
......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40558/8/src/soc/intel/common/block/...
File src/soc/intel/common/block/smbus/smbuslib.c:
https://review.coreboot.org/c/coreboot/+/40558/8/src/soc/intel/common/block/...
PS8, Line 50: memset(spd, 0, CONFIG_DIMM_SPD_SIZE);
nit: I think you can avoid doing this memset and instead return a -1 which can be checked by the cal […]
Done
https://review.coreboot.org/c/coreboot/+/40558/8/src/soc/intel/common/block/...
PS8, Line 79: if (spd_data[i * CONFIG_DIMM_SPD_SIZE] != 0)
: blk->spd_array[i] = &spd_data[i * CONFIG_DIMM_SPD_SIZE];
: else
: blk->spd_array[i] = NULL;
Continuing my comment above: This can be changed to: […]
okay, this is better 🎉
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40558
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie81adbfab5bb1d5c557fe549a158cb68e26b1162
Gerrit-Change-Number: 40558
Gerrit-PatchSet: 9
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Varun Joshi
varun.joshi@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bora Guvendik
bora.guvendik@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Selma Bensaid
selma.bensaid@intel.corp-partner.google.com
Gerrit-Comment-Date: Thu, 23 Apr 2020 15:47:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment