Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37043 )
Change subject: drivers/spi/flashconsole.c: Drop CAR_GLOBAL_MIGRATION support
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37043/7/src/drivers/spi/flashconsol...
File src/drivers/spi/flashconsole.c:
https://review.coreboot.org/c/coreboot/+/37043/7/src/drivers/spi/flashconsol...
PS7, Line 93: if (!rdev)
: return;
g_rdev_ptr may be null (before flashconsole_init), so leave a test like this in?
See CB:37375
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37043
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I81a610a6d119745f2fc637629b8ba7ade76503bc
Gerrit-Change-Number: 37043
Gerrit-PatchSet: 8
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 30 Nov 2019 09:55:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment