Attention is currently required from: Bora Guvendik, Zhixing Ma, Anil Kumar K, Hannah Williams, Cliff Huang, Nico Huber, Michał Żygowski, Subrata Banik, Jérémy Compostella, Paul Menzel, Arthur Heymans, Swift Geek (Sebastian Grzywna).
Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70299 )
Change subject: soc/intel/common/block: Add Intel VGA early graphics support
......................................................................
Patch Set 32:
(1 comment)
File src/soc/intel/common/block/graphics/early_graphics.c:
https://review.coreboot.org/c/coreboot/+/70299/comment/6caaa8de_f6454b09
PS23, Line 32:
: /*
: * Graphics MMIO device configuration may have been corrupted since it
: * has been initialized. The execution of a binary block such as FSP may
: * indeed have reset the PCI BAR0 address of the graphic device.
: */
: early_graphics_soc_device_init();
If coreboot uses `0xfa000000`, Linux has to reallocate. […]
@Jeremy can we reach out to someone on the Kernel side and see if there may be any unintended side-effects of the realloc?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70299
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie4ad1215e5fadd0adc1271b6bd6ddb0ea258cb5b
Gerrit-Change-Number: 70299
Gerrit-PatchSet: 32
Gerrit-Owner: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Swift Geek (Sebastian Grzywna)
swiftgeek@gmail.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Zhixing Ma
zhixing.ma@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-CC: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Zhixing Ma
zhixing.ma@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Swift Geek (Sebastian Grzywna)
swiftgeek@gmail.com
Gerrit-Comment-Date: Mon, 09 Jan 2023 20:19:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tarun Tuli
taruntuli@google.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-MessageType: comment