Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31566 )
Change subject: soc/cavium/common: Make ecam0_get_bar_val common
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/31566/1/src/soc/cavium/common/ecam.c
File src/soc/cavium/common/ecam.c:
https://review.coreboot.org/#/c/31566/1/src/soc/cavium/common/ecam.c@70
PS1, Line 70: + 4);
I think we have functions for reading base from 64bit bars. If we don't one should be added. Not the scope of this, though.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31566
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I18b1ede56795bf8c1f9476592291b8ea610eccd4
Gerrit-Change-Number: 31566
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 22 Feb 2019 19:18:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment