Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45343 )
Change subject: device/dram: Add method for converting MHz to MT/s
......................................................................
Patch Set 6: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/45343/6/src/device/dram/ddr4.c
File src/device/dram/ddr4.c:
https://review.coreboot.org/c/coreboot/+/45343/6/src/device/dram/ddr4.c@14
PS6, Line 14: DDR4_UNSPECIFIED
nit: I am not sure what purpose this serves since we don't really use it for anything now except reserving an empty entry in ddr4_speeds[] table which I think is not really necessary.
https://review.coreboot.org/c/coreboot/+/45343/6/src/device/dram/ddr4.c@150
PS6, Line 150: DDR4
nit: Add "ERROR:" so that log parsing scripts catch this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45343
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1433f028afb794fe3e397b03f5bd0565494c8130
Gerrit-Change-Number: 45343
Gerrit-PatchSet: 6
Gerrit-Owner: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 15 Sep 2020 22:18:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment