Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39342 )
Change subject: vboot: remove VBOOT_NO_BOARD_SUPPORT Kconfig
......................................................................
Patch Set 1:
Patch Set 1:
I'm ambivalent about this one. There was a point to adding this Kconfig in the first place -- to make sure that boards that want the full vboot experience cannot forget to define this, and that boards have to consciously select something to acknowledge that they won't get working recovery mode.
Then again, if everyone thinks this is just an unnecessary hassle I'm okay with removing it.
I'm fine with keeping it -- but the existing Kconfig description implies that it should be removed. I can just reword it, if we feel that's the better option.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39342
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iccef100fac1d71625039990373e40b29d52a0167
Gerrit-Change-Number: 39342
Gerrit-PatchSet: 1
Gerrit-Owner: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 07 Mar 2020 02:55:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment