Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38741 )
Change subject: soc/intel/cannonlake: Add tdc config for CML
......................................................................
Patch Set 15: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/38741/15//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38741/15//COMMIT_MSG@7
PS15, Line 7: tdc
nit, this should be uppercase: TDC
https://review.coreboot.org/c/coreboot/+/38741/15/src/soc/intel/cannonlake/v...
File src/soc/intel/cannonlake/vr_config.c:
https://review.coreboot.org/c/coreboot/+/38741/15/src/soc/intel/cannonlake/v...
PS15, Line 506: printk(BIOS_ERR, "ERROR: Unknown MCH (0x%x) in VR-config, so apply defaults\n", mch_id);
This looks like it is still over the limit?
I believe so. I think you can drop the "default" clause, or use the same string as in other functions (without "so apply defaults")
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38741
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie4b17e5b4ce41c1adb436ae5646f0d8578a440e8
Gerrit-Change-Number: 38741
Gerrit-PatchSet: 15
Gerrit-Owner: Marx Wang
marx.wang@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Marx Wang
marx.wang@intel.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marx Wang
marx.wang@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 24 Feb 2020 15:35:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Comment-In-Reply-To: Marx Wang
marx.wang@intel.com
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment