[coreboot-gerrit] Change in coreboot[master]: src/soc/intel: Add support for CAR_HAS_SF_MASKS and select for TGL

[Shreesh Chhabbi (Code Review)]

Shreesh Chhabbi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48286 )

Change subject: src/soc/intel: Add support for CAR_HAS_SF_MASKS and select for TGL
......................................................................

Patch Set 18:

(3 comments)

https://review.coreboot.org/c/coreboot/+/48286/18//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/48286/18//COMMIT_MSG@15 
PS18, Line 15: 32:33
> You are correct. It does.

Done

https://review.coreboot.org/c/coreboot/+/48286/18/src/soc/intel/common/block... 
File src/soc/intel/common/block/cpu/car/exit_car.S:

https://review.coreboot.org/c/coreboot/+/48286/18/src/soc/intel/common/block... 
PS18, Line 94: 	/* Reset CLOS selector to 0 */
             : 	mov	$IA32_PQR_ASSOC, %ecx
             : 	rdmsr
             : 	and	$~IA32_PQR_ASSOC_MASK, %edx
             : 	wrmsr
> There is definitely some inconsistency here. […]

Yes Furquan. Agreed. We can do this.

https://review.coreboot.org/c/coreboot/+/48286/18/src/soc/intel/common/block... 
PS18, Line 99:
> Are you planning to add a comment here indicating why masks are not programmed during teardown?

Done