Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45078 )
Change subject: soc/intel/elkhartlake: Update Kconfig ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45078/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45078/4//COMMIT_MSG@10 PS4, Line 10: 1. use FSP2.1 instead of 2.2
Why? Isn’t it a newer platform?
EHL will still only support FSP2.1 because FSP2.2 comes pretty late during our development stage and EHL doesn't support chrome OS hence there is no need to upgrade it for now.
https://review.coreboot.org/c/coreboot/+/45078/4//COMMIT_MSG@17 PS4, Line 17: 8. update UART base address
I’d prefer one commit for each item.
I could do that but not prefer to as that would create 20+ patches just to update kconfig in mainboard & soc 😄 Hence i added detailed changes in the patches. Of cause those kconfig params that tied to other bigger changes i didn't included in and will submitted in other patches. Does this make sense to you?