Attention is currently required from: Derek Huang, Leo Chou, Shou-Chieh Hsu, Tarun Tuli.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75900?usp=email )
Change subject: mb/google/nissa/var/pujjo: Tuning SX9324 register for pujjoteen5
......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75900/comment/f7977fbe_8a7a3773 :
PS4, Line 7: Tuning
Imperative mood: Tune
https://review.coreboot.org/c/coreboot/+/75900/comment/8d27bd71_aaf93f7a :
PS4, Line 10: P-sensor vendor
Who is that?
https://review.coreboot.org/c/coreboot/+/75900/comment/2aa74197_c54b2ba2 :
PS4, Line 13: TEST=i2cdump -y -f 13 0x28 on Pujjoteen5
What is the output?
https://review.coreboot.org/c/coreboot/+/75900/comment/318f4fe5_89e1cd76 :
PS4, Line 14:
What user visible change is visible?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75900?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idc9a2dc817e027551e209c0a26eeebad398f710c
Gerrit-Change-Number: 75900
Gerrit-PatchSet: 4
Gerrit-Owner: Leo Chou
leo.chou@lcfc.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jerry2 Huang
jerry2.huang@lcfc.corp-partner.google.com
Gerrit-CC: Joey Peng
joey.peng@lcfc.corp-partner.google.com
Gerrit-CC: Jynn Chen
jynn.chen@lcfc.corp-partner.google.com
Gerrit-CC: Kevin3 Yang
kevin3.yang@lcfc.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Derek Huang
derekhuang@google.com
Gerrit-Attention: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Attention: Leo Chou
leo.chou@lcfc.corp-partner.google.com
Gerrit-Comment-Date: Sat, 17 Jun 2023 07:01:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment