Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42320 )
Change subject: util/mtkheader: Port gen-bl-img.py to python3
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42320/3/util/mtkheader/gen-bl-img.p...
File util/mtkheader/gen-bl-img.py:
https://review.coreboot.org/c/coreboot/+/42320/3/util/mtkheader/gen-bl-img.p...
PS3, Line 80: output_file
While you're updating this code to python3, may I suggest using string literals instead?
print(f"Usage: {argv[0]} ...")
https://docs.python.org/3/reference/lexical_analysis.html#formatted-string-l...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42320
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia7b46093f1dcecd03d16fbe5f37d1aae7679bac3
Gerrit-Change-Number: 42320
Gerrit-PatchSet: 3
Gerrit-Owner: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Idwer Vollering
vidwer@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 17 Jun 2020 12:42:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment