Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42505 )
Change subject: libpayload: gdb: Condition video console init on LP_VIDEO_CONSOLE ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/42505/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42505/1//COMMIT_MSG@7 PS1, Line 7: libpayload: Initialize video console conditionally
While you guys are updating the subject it should probably say 'libpayload: gdb: ' or something to c […]
Done
https://review.coreboot.org/c/coreboot/+/42505/1//COMMIT_MSG@9 PS1, Line 9: Initialize video console only if LP_VIDEO_CONSOLE is set.
What problem does this solve?
Done
https://review.coreboot.org/c/coreboot/+/42505/1//COMMIT_MSG@13 PS1, Line 13: TEST
Just to confirm, does this let us compile depthcharge without defining video_console_init?
Yes. If this is what you're asking, together with CL:2241493,
emerge-gale depthcharge
succeeded.
https://review.coreboot.org/c/coreboot/+/42505/1/payloads/libpayload/gdb/stu... File payloads/libpayload/gdb/stub.c:
https://review.coreboot.org/c/coreboot/+/42505/1/payloads/libpayload/gdb/stu... PS1, Line 76: puts("GDB died, redirecting its last words to the screen:\n");
No, this is supposed to be visible on the screen, so it needs to come after video_console_init(). […]
Done