Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36823 )
Change subject: soc/amd/stoneyridge/kconfig: Make Prairie Falcon selection explicit
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36823/4/src/soc/amd/stoneyridge/Mak...
File src/soc/amd/stoneyridge/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/36823/4/src/soc/amd/stoneyridge/Mak...
PS4, Line 140: ifeq ($(CONFIG_SOC_AMD_MERLINFALCON),y)
:
: ifeq ($(CONFIG_HAVE_MERLINFALCON_BINARIES),y)
: FIRMWARE_TYPE=CZ
: else
: FIRMWARE_TYPE=ST
: endif
My point is this. […]
So maybe change commit message? The truth is, I can't remove this until binaries are available... but AMD wanted Prairie Falcon, which is available "under the hood" and I'm the only one who knew it. So I made Prairie Falcon explicitly available.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36823
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I309c5918fdc98d9927641466bbe6149b97b250f0
Gerrit-Change-Number: 36823
Gerrit-PatchSet: 4
Gerrit-Owner: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 19 Nov 2019 13:01:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Comment-In-Reply-To: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-MessageType: comment