Attention is currently required from: Arthur Heymans, Matt DeVillier, MrChromebox.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61563 )
Change subject: mb/google/octopus,reef: Align SMMSTORE region in default.fmd
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
I'm trying to remember why the specifying the start address here is even needed, given that it would […]
yeah should be `0x200000` if I did my math right
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61563
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5d4f71f80c3219ac2c7000e1fa95fd04100d9cfe
Gerrit-Change-Number: 61563
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: MrChromebox
mrchromebox@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: MrChromebox
mrchromebox@gmail.com
Gerrit-Comment-Date: Fri, 04 Feb 2022 21:49:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Gerrit-MessageType: comment