23 Dec
2020
23 Dec
'20
4:25 p.m.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48602 )
Change subject: nb/intel/sandybridge: Add comment to TC_RWP write ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/48602/2/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit_common.c:
https://review.coreboot.org/c/coreboot/+/48602/2/src/northbridge/intel/sandy... PS2, Line 1893: 1 << 27 might be worth adding a define for this (or a bitfield if you prefer that) for this in a follow-up patch
--
To view, visit https://review.coreboot.org/c/coreboot/+/48602
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I164daa59696f2fe8de3a4b3e7da46c7c723778eb
Gerrit-Change-Number: 48602
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 23 Dec 2020 15:25:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment