Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45056 )
Change subject: soc/amd/picasso/acpi: Add MADT entry for NB ioapic, if initialized.
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45056/5/src/soc/amd/picasso/acpi.c
File src/soc/amd/picasso/acpi.c:
https://review.coreboot.org/c/coreboot/+/45056/5/src/soc/amd/picasso/acpi.c@...
PS5, Line 59: CONFIG_MAX_CPUS
I think we should do one of two things:
1. FSP has definies for io apic ids use here through fsp headers.
2. Add Kconfigs for the ids.
We shouldn't make these ids dependent on CONFIG_MAX_CPUS because we know things are being hard coded in FSP at the moment.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45056
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic4a2e9b71dba948e8a4907e5f97131426d8a4a3e
Gerrit-Change-Number: 45056
Gerrit-PatchSet: 5
Gerrit-Owner: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 03 Sep 2020 21:44:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment