Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/82115?usp=email )
Change subject: soc/intel/alderlake: Default to 512 for DIMM_SPD_SIZE ......................................................................
soc/intel/alderlake: Default to 512 for DIMM_SPD_SIZE
Alderlake and Raptorlake SoCs support DDR4 and DDR5, which have a total SPD size of 512 bytes. Set this as the default and remove the setting from mainboard Kconfigs.
Change-Id: I8703ec25454a0cd55a3de70f73d2117285a833ae Signed-off-by: Felix Singer felixsinger@posteo.net Reviewed-on: https://review.coreboot.org/c/coreboot/+/82115 Reviewed-by: Eric Lai ericllai@google.com Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/brox/Kconfig M src/mainboard/google/brya/Kconfig M src/mainboard/intel/adlrvp/Kconfig M src/mainboard/intel/shadowmountain/Kconfig M src/mainboard/msi/ms7d25/Kconfig M src/mainboard/msi/ms7e06/Kconfig M src/mainboard/prodrive/atlas/Kconfig M src/mainboard/system76/adl/Kconfig M src/mainboard/system76/rpl/Kconfig M src/soc/intel/alderlake/Kconfig 10 files changed, 3 insertions(+), 27 deletions(-)
Approvals: Eric Lai: Looks good to me, approved build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/google/brox/Kconfig b/src/mainboard/google/brox/Kconfig index 0ec5220..77ba5db 100644 --- a/src/mainboard/google/brox/Kconfig +++ b/src/mainboard/google/brox/Kconfig @@ -131,9 +131,6 @@ config VBOOT select VBOOT_LID_SWITCH
-config DIMM_SPD_SIZE - default 512 - config UART_FOR_CONSOLE int default 0 diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index 1565f13..79b54f0 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -817,9 +817,6 @@ select VBOOT_EARLY_EC_SYNC if !BOARD_GOOGLE_BASEBOARD_NISSA select VBOOT_LID_SWITCH
-config DIMM_SPD_SIZE - default 512 - config UART_FOR_CONSOLE int default 0 diff --git a/src/mainboard/intel/adlrvp/Kconfig b/src/mainboard/intel/adlrvp/Kconfig index 1083ce2..5ee091b 100644 --- a/src/mainboard/intel/adlrvp/Kconfig +++ b/src/mainboard/intel/adlrvp/Kconfig @@ -135,9 +135,6 @@ config OVERRIDE_DEVICETREE default "variants/$(CONFIG_VARIANT_DIR)/overridetree.cb"
-config DIMM_SPD_SIZE - default 512 - choice prompt "ON BOARD EC" default ADL_CHROME_EC if BOARD_INTEL_ADLRVP_P_EXT_EC || BOARD_INTEL_ADLRVP_P_MCHP || BOARD_INTEL_ADLRVP_N_EXT_EC || BOARD_INTEL_ADLRVP_RPL_EXT_EC diff --git a/src/mainboard/intel/shadowmountain/Kconfig b/src/mainboard/intel/shadowmountain/Kconfig index 17c0014..f01479b 100644 --- a/src/mainboard/intel/shadowmountain/Kconfig +++ b/src/mainboard/intel/shadowmountain/Kconfig @@ -42,9 +42,6 @@ select HAS_RECOVERY_MRC_CACHE select VBOOT_EARLY_EC_SYNC
-config DIMM_SPD_SIZE - default 512 - config DEVICETREE default "variants/baseboard/devicetree.cb"
diff --git a/src/mainboard/msi/ms7d25/Kconfig b/src/mainboard/msi/ms7d25/Kconfig index 3fb6f40..ab9fa2b 100644 --- a/src/mainboard/msi/ms7d25/Kconfig +++ b/src/mainboard/msi/ms7d25/Kconfig @@ -41,9 +41,6 @@ string default "2.0" if BOARD_MSI_Z690_A_PRO_WIFI_DDR5
-config DIMM_SPD_SIZE - default 512 - config UART_FOR_CONSOLE int default 0 diff --git a/src/mainboard/msi/ms7e06/Kconfig b/src/mainboard/msi/ms7e06/Kconfig index c46effc..cfa6447 100644 --- a/src/mainboard/msi/ms7e06/Kconfig +++ b/src/mainboard/msi/ms7e06/Kconfig @@ -34,9 +34,6 @@ config MAINBOARD_FAMILY default "Default string"
-config DIMM_SPD_SIZE - default 512 - config UART_FOR_CONSOLE default 0
diff --git a/src/mainboard/prodrive/atlas/Kconfig b/src/mainboard/prodrive/atlas/Kconfig index 5a3f311..b40e2b7 100644 --- a/src/mainboard/prodrive/atlas/Kconfig +++ b/src/mainboard/prodrive/atlas/Kconfig @@ -47,9 +47,6 @@ string default "Prodrive Technologies B.V."
-config DIMM_SPD_SIZE - default 512 - config UART_FOR_CONSOLE int default 0 diff --git a/src/mainboard/system76/adl/Kconfig b/src/mainboard/system76/adl/Kconfig index 5213cfe..3d364f1 100644 --- a/src/mainboard/system76/adl/Kconfig +++ b/src/mainboard/system76/adl/Kconfig @@ -103,9 +103,6 @@ config D3COLD_SUPPORT default n
-config DIMM_SPD_SIZE - default 512 - config FMDFILE default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/board.fmd"
diff --git a/src/mainboard/system76/rpl/Kconfig b/src/mainboard/system76/rpl/Kconfig index 2a850ae..60ea71b 100644 --- a/src/mainboard/system76/rpl/Kconfig +++ b/src/mainboard/system76/rpl/Kconfig @@ -125,9 +125,6 @@ config D3COLD_SUPPORT default n
-config DIMM_SPD_SIZE - default 512 - config FMDFILE default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/variants/$(CONFIG_VARIANT_DIR)/board.fmd"
diff --git a/src/soc/intel/alderlake/Kconfig b/src/soc/intel/alderlake/Kconfig index 5086069..b124b14 100644 --- a/src/soc/intel/alderlake/Kconfig +++ b/src/soc/intel/alderlake/Kconfig @@ -146,6 +146,9 @@
if SOC_INTEL_ALDERLAKE
+config DIMM_SPD_SIZE + default 512 + config SOC_INTEL_ALDERLAKE_TCSS_USB4_SUPPORT bool default n if SOC_INTEL_ALDERLAKE_PCH_S