build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46392 )
Change subject: soc/mediatek/mt8192: Load MCUPM firmware and boot up MCUPM. ......................................................................
Patch Set 1:
(17 comments)
https://review.coreboot.org/c/coreboot/+/46392/1/src/soc/mediatek/mt8192/inc... File src/soc/mediatek/mt8192/include/soc/addressmap.h:
https://review.coreboot.org/c/coreboot/+/46392/1/src/soc/mediatek/mt8192/inc... PS1, Line 8: MCUPM_SRAM_BASE = 0x0C540000, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/46392/1/src/soc/mediatek/mt8192/inc... PS1, Line 9: MCUPM_CFG_BASE = 0x0C560000, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/46392/1/src/soc/mediatek/mt8192/mcu... File src/soc/mediatek/mt8192/mcupm.c:
https://review.coreboot.org/c/coreboot/+/46392/1/src/soc/mediatek/mt8192/mcu... PS1, Line 15: const char *file_name = "mcupm.bin"; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/46392/1/src/soc/mediatek/mt8192/mcu... PS1, Line 16: size_t fw_size = cbfs_boot_load_file(file_name, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/46392/1/src/soc/mediatek/mt8192/mcu... PS1, Line 17: mcupm_bin, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/46392/1/src/soc/mediatek/mt8192/mcu... PS1, Line 17: mcupm_bin, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/46392/1/src/soc/mediatek/mt8192/mcu... PS1, Line 18: sizeof(mcupm_bin), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/46392/1/src/soc/mediatek/mt8192/mcu... PS1, Line 18: sizeof(mcupm_bin), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/46392/1/src/soc/mediatek/mt8192/mcu... PS1, Line 19: CBFS_TYPE_RAW); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/46392/1/src/soc/mediatek/mt8192/mcu... PS1, Line 19: CBFS_TYPE_RAW); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/46392/1/src/soc/mediatek/mt8192/mcu... PS1, Line 21: if (fw_size == 0) { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/46392/1/src/soc/mediatek/mt8192/mcu... PS1, Line 21: if (fw_size == 0) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/46392/1/src/soc/mediatek/mt8192/mcu... PS1, Line 22: die("MCUPM file :mcupm.bin not found."); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/46392/1/src/soc/mediatek/mt8192/mcu... PS1, Line 22: die("MCUPM file :mcupm.bin not found."); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/46392/1/src/soc/mediatek/mt8192/mcu... PS1, Line 23: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/46392/1/src/soc/mediatek/mt8192/mcu... PS1, Line 27: memcpy((void *)MCUPM_SRAM_BASE, mcupm_bin, fw_size); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/46392/1/src/soc/mediatek/mt8192/soc... File src/soc/mediatek/mt8192/soc.c:
https://review.coreboot.org/c/coreboot/+/46392/1/src/soc/mediatek/mt8192/soc... PS1, Line 17: mcupm_init(); please, no spaces at the start of a line