build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73392 )
Change subject: [WIP]mb/ibm: Add IBM SBP1 ......................................................................
Patch Set 1:
(28 comments)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171308): https://review.coreboot.org/c/coreboot/+/73392/comment/b4b6d357_2b779886 PS1, Line 17: 'managment' may be misspelled - perhaps 'management'?
File src/mainboard/ibm/sbp1/bootblock.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171308): https://review.coreboot.org/c/coreboot/+/73392/comment/d309624d_430be5a8 PS1, Line 15: #define PCR_DMI_LPCIOD 0x2770 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171308): https://review.coreboot.org/c/coreboot/+/73392/comment/1a3d1a20_ec314752 PS1, Line 16: #define PCR_DMI_LPCIOE 0x2774 please, no space before tabs
File src/mainboard/ibm/sbp1/include/spr_sbp1_gpio.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171308): https://review.coreboot.org/c/coreboot/+/73392/comment/01198acd_974aaefc PS1, Line 242: _PAD_CFG_STRUCT(GPP_D22, \ Avoid unnecessary line continuations
File src/mainboard/ibm/sbp1/romstage.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171308): https://review.coreboot.org/c/coreboot/+/73392/comment/46d669c4_4e11d8c6 PS1, Line 11: #define CFG_UPD_PCIE_PORT(pexphide, slotimp, slotpsp) \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171308): https://review.coreboot.org/c/coreboot/+/73392/comment/1a1206cd_1ac08dac PS1, Line 13: .SLOTEIP = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171308): https://review.coreboot.org/c/coreboot/+/73392/comment/243fd779_b166ed04 PS1, Line 15: .SLOTHPSUP = slotimp, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171308): https://review.coreboot.org/c/coreboot/+/73392/comment/598ed967_2faad2fa PS1, Line 16: .SLOTPIP = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171308): https://review.coreboot.org/c/coreboot/+/73392/comment/66008163_7e159285 PS1, Line 17: .SLOTAIP = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171308): https://review.coreboot.org/c/coreboot/+/73392/comment/ca33e97e_96f27b5c PS1, Line 18: .SLOTMRLSP = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171308): https://review.coreboot.org/c/coreboot/+/73392/comment/476f470d_c7f8255e PS1, Line 19: .SLOTPCP = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171308): https://review.coreboot.org/c/coreboot/+/73392/comment/4dffb63d_31cf643c PS1, Line 20: .SLOTABP = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171308): https://review.coreboot.org/c/coreboot/+/73392/comment/87a7a68a_e61094c9 PS1, Line 21: .SLOTIMP = slotimp, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171308): https://review.coreboot.org/c/coreboot/+/73392/comment/d107266c_d85e7dda PS1, Line 22: .SLOTSPLS = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171308): https://review.coreboot.org/c/coreboot/+/73392/comment/b573ec6e_3ee310bf PS1, Line 23: .SLOTSPLV = slotimp ? 25 : 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171308): https://review.coreboot.org/c/coreboot/+/73392/comment/7f3e8d36_2e898d4d PS1, Line 24: .SLOTPSP = slotpsp, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171308): https://review.coreboot.org/c/coreboot/+/73392/comment/372cf4b2_23f7385b PS1, Line 25: .VppEnabled = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171308): https://review.coreboot.org/c/coreboot/+/73392/comment/a4e8a951_f39d60a6 PS1, Line 26: .VppPort = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171308): https://review.coreboot.org/c/coreboot/+/73392/comment/30777eb3_84d645cb PS1, Line 27: .VppAddress = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171308): https://review.coreboot.org/c/coreboot/+/73392/comment/b4d22ef4_faf13337 PS1, Line 28: .MuxAddress = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171308): https://review.coreboot.org/c/coreboot/+/73392/comment/a181723b_08134117 PS1, Line 29: .ChannelID = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171308): https://review.coreboot.org/c/coreboot/+/73392/comment/5d0b73e7_185163ff PS1, Line 30: .PciePortEnable = !pexphide, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171308): https://review.coreboot.org/c/coreboot/+/73392/comment/e213d6c3_afc916c7 PS1, Line 31: .PEXPHIDE = pexphide, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171308): https://review.coreboot.org/c/coreboot/+/73392/comment/577a94db_01b28e35 PS1, Line 32: .HidePEXPMenu = pexphide, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171308): https://review.coreboot.org/c/coreboot/+/73392/comment/6a512abf_de32f593 PS1, Line 33: .PciePortOwnership = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171308): https://review.coreboot.org/c/coreboot/+/73392/comment/695b581b_fa25e166 PS1, Line 34: .RetimerConnectCount = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171308): https://review.coreboot.org/c/coreboot/+/73392/comment/386738dd_23d95a08 PS1, Line 322: UINT8 *DeEmphasisConfig = (UINT8*) deemphasis_list; "(foo*)" should be "(foo *)"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171308): https://review.coreboot.org/c/coreboot/+/73392/comment/f5eec673_96e42c04 PS1, Line 324: for (port = 0; port < CONFIG_MAX_SOCKET * MAX_IIO_PORTS_PER_SOCKET; port++) that open brace { should be on the previous line