Kyösti Mälkki has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34926 )
Change subject: google/butterfly: Replace use of __PRE_RAM__ ......................................................................
google/butterfly: Replace use of __PRE_RAM__
Change-Id: Iae944b589d587b30826e935feae029aa8d07d5d9 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34926 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com --- M src/mainboard/google/butterfly/chromeos.c 1 file changed, 10 insertions(+), 11 deletions(-)
Approvals: build bot (Jenkins): Verified Marshall Dawson: Looks good to me, approved
diff --git a/src/mainboard/google/butterfly/chromeos.c b/src/mainboard/google/butterfly/chromeos.c index 2825aae..635aaee 100644 --- a/src/mainboard/google/butterfly/chromeos.c +++ b/src/mainboard/google/butterfly/chromeos.c @@ -66,18 +66,17 @@ { int ec_rec_mode = 0;
-#if FORCE_RECOVERY_MODE - printk(BIOS_DEBUG,"FORCING RECOVERY MODE.\n"); - return 1; -#endif - - -#ifndef __PRE_RAM__ - if (ec_mem_read(EC_CODE_STATE) == EC_COS_EC_RO) { - ec_rec_mode = 1; + if (FORCE_RECOVERY_MODE) { + printk(BIOS_DEBUG, "FORCING RECOVERY MODE.\n"); + return 1; } - printk(BIOS_DEBUG,"RECOVERY MODE FROM EC: %x\n", ec_rec_mode); -#endif + + if (ENV_RAMSTAGE) { + if (ec_mem_read(EC_CODE_STATE) == EC_COS_EC_RO) + ec_rec_mode = 1; + + printk(BIOS_DEBUG, "RECOVERY MODE FROM EC: %x\n", ec_rec_mode); + }
return ec_rec_mode; }