Attention is currently required from: Subrata Banik, Maulik V Vaghela, Tim Wawrzynczak, Paul Menzel, Sugnan Prabhu S.
Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61020 )
Change subject: src/driver/wifi: Add _DSM method for DDRRFIM
......................................................................
Patch Set 19:
(5 comments)
File src/drivers/wifi/generic/acpi.c:
https://review.coreboot.org/c/coreboot/+/61020/comment/36d34608_6b060812
PS18, Line 40: //bool is_cnviDdrRfim_enabled = false;
delete this
Done
https://review.coreboot.org/c/coreboot/+/61020/comment/6aa2ee6b_a21a8ce4
PS18, Line 160: bool *is_cnvi_ddr_rfim_enabled = false;
This is creating a pointer that points to the value `false`, presumably 0... […]
Done
https://review.coreboot.org/c/coreboot/+/61020/comment/b2a9086e_b5fc4616
PS18, Line 542: bool *is_cnviDdrRfim_enabled = false;
: *is_cnviDdrRfim_enabled = config->enable_cnvi_ddr_rfim;
This would look cleaner if we just use a regular bool here, e.g. […]
Done
https://review.coreboot.org/c/coreboot/+/61020/comment/9a257114_094a8707
PS18, Line 606: if (*is_cnviDdrRfim_enabled)
then […]
Done
https://review.coreboot.org/c/coreboot/+/61020/comment/a7c2bc4e_82e711f0
PS18, Line 610: dsm_ids[dsm_count].arg = (void *)is_cnviDdrRfim_enabled;
`dsm_ids[dsm_count]. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61020
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I217b736df3d4224a6732d1941a160abcddbd8f37
Gerrit-Change-Number: 61020
Gerrit-PatchSet: 19
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Haribalaraman Ramasubramanian
haribalaraman.r@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-CC: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Comment-Date: Fri, 04 Mar 2022 18:18:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment