Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30826 )
Change subject: security/tpm/tss/tcg-2.0: Add TPM2 function tlcl_getcapability() ......................................................................
Patch Set 18:
(5 comments)
https://review.coreboot.org/c/coreboot/+/30826/4/src/security/tpm/tss.h File src/security/tpm/tss.h:
https://review.coreboot.org/c/coreboot/+/30826/4/src/security/tpm/tss.h@125 PS4, Line 125: #if IS_ENABLED(CONFIG_TPM2)
Please add the TPM2-only stuff to the existing CONFIG(TPM2) block above. […]
Done
https://review.coreboot.org/c/coreboot/+/30826/4/src/security/tpm/tss.h@130 PS4, Line 130: uint32_t propertyCount, TPMI_YES_NO *moreData,
need consistent spacing around '*' (ctx:WxV)
Done
https://review.coreboot.org/c/coreboot/+/30826/4/src/security/tpm/tss.h@131 PS4, Line 131: TPMS_CAPABILITY_DATA *capabilityData);
need consistent spacing around '*' (ctx:WxV)
Done
https://review.coreboot.org/c/coreboot/+/30826/4/src/security/tpm/tss.h@136 PS4, Line 136: void *tpm_process_command_ex(TPM_CC command, void *command_body,
Please don't just create a new function for the same thing. […]
Done
https://review.coreboot.org/c/coreboot/+/30826/4/src/security/tpm/tss.h@144 PS4, Line 144: uint32_t tlcl_extend_ex(int pcr_num, const TPML_DIGEST_VALUES *in_digests);
Same here, please update the existing tlcl_extend() to be more flexible, we don't need two extend fu […]
Done