Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39893 )
Change subject: Documentation: Add proposal for firmware unit testing ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/c/coreboot/+/39893/1/Documentation/technotes/202... File Documentation/technotes/2020-03-unit-testing-coreboot.md:
https://review.coreboot.org/c/coreboot/+/39893/1/Documentation/technotes/202... PS1, Line 100: GPL compatible to GPL? BSD-l wouldn't raise questions, while Apache-l might do (even though we don't distribute the binaries)
https://review.coreboot.org/c/coreboot/+/39893/1/Documentation/technotes/202... PS1, Line 105: for obvious reasons "because that would take an excessive amount of time"? Not sure we should talk about "obvious" in documentation.
https://review.coreboot.org/c/coreboot/+/39893/1/Documentation/technotes/202... PS1, Line 176: Pros please take care of trailing whitespace
https://review.coreboot.org/c/coreboot/+/39893/1/Documentation/technotes/202... PS1, Line 195: In the same time At the same time (also a couple of times elsewhere in the doc), see e.g. https://www.italki.com/question/337681
https://review.coreboot.org/c/coreboot/+/39893/1/Documentation/technotes/202... PS1, Line 206: form from