[coreboot-gerrit] Change in coreboot[master]: mediatek/mt8192: add spmfw loader

[Yidi Lin (Code Review)]

Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46389 )

Change subject: mediatek/mt8192: add spmfw loader
......................................................................

Patch Set 26:

(2 comments)

https://review.coreboot.org/c/coreboot/+/46389/25/src/soc/mediatek/mt8192/sp... 
File src/soc/mediatek/mt8192/spm.c:

https://review.coreboot.org/c/coreboot/+/46389/25/src/soc/mediatek/mt8192/sp... 
PS25, Line 21: 	.reg_wfi_op = 0,
             : 	.reg_wfi_type = 0,
             : 	.reg_mp0_cputop_idle_mask = 0,
             : 	.reg_mp1_cputop_idle_mask = 0,
             : 	.reg_mcusys_idle_mask = 0,
             : 	.reg_md_apsrc_1_sel = 0,
             : 	.reg_md_apsrc_0_sel = 0,
             : 	.reg_conn_apsrc_sel = 0,
             :
> static variable is always 0, so please remove the =0 fields.

Done

https://review.coreboot.org/c/coreboot/+/46389/25/src/soc/mediatek/mt8192/sp... 
PS25, Line 438: settle
> never used?

Done