Attention is currently required from: Дмитрий Понаморев, Mariusz Szafrański, Paul Menzel, Suresh Bellampalli, Vanessa Eusebio, Michal Motyl, Patrick Rudolph, King Sumo. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57194 )
Change subject: src/mainboard/teleplatforms/D4E4S16P8: Add new CRB teleplatforms/D4E4S16P8 folder. ......................................................................
Patch Set 17:
(6 comments)
File src/mainboard/teleplatforms/D4E4S16P8/Kconfig:
https://review.coreboot.org/c/coreboot/+/57194/comment/d1cf6131_866f596f PS17, Line 14: ## I'll adjust the licenses to one-liners.
https://review.coreboot.org/c/coreboot/+/57194/comment/16c138f7_1e508e96 PS17, Line 42: config ENABLE_FSP_MEMORY_DOWN Board has DIMM slots, I'll separate this feature as debugging aid, and it's unlikely to be merged.
File src/mainboard/teleplatforms/D4E4S16P8/boardid.c:
https://review.coreboot.org/c/coreboot/+/57194/comment/58493fa2_e7088248 PS17, Line 6: uint8_t board_id(void) No real board_id(), I will remove.
IMO this would mostly have use if your board had some GPIOs to read PCB revision and firmware would have to that into account somehow. Otherwise, a different board would be typically described as a variant and Kconfig choice.
File src/mainboard/teleplatforms/D4E4S16P8/emmc.h:
https://review.coreboot.org/c/coreboot/+/57194/comment/fa1b28b5_c4f1c978 PS17, Line 11: BL_EMMC_INFORMATION D4E4S16P8_emmc_config[] = { eMMC is not routed and 0:1c.0 should not be enabled, I'll remove this file
File src/mainboard/teleplatforms/D4E4S16P8/romstage.c:
https://review.coreboot.org/c/coreboot/+/57194/comment/48ed71f4_c92e7aa9 PS17, Line 102: if (!CONFIG(ENABLE_FSP_MEMORY_DOWN)) You would never set this for a board with DIMM slots, except for occasional debug use if reading SPD over SMBus failed. I will separate the spd/ directory and have it available for you, but not likely to be merged.
File src/mainboard/teleplatforms/D4E4S16P8/smbus.c:
https://review.coreboot.org/c/coreboot/+/57194/comment/8cea34c2_fe277647 PS17, Line 81: .device = 0x19df, /* Denverton SMBus0 "Legacy" device id */ This file is not specific to your board, I'll remove it here. We should have a working copy under soc/intel somewhere so the feature this implements can still work if you need it.