[coreboot-gerrit] Change in coreboot[master]: soc/amd/common/block/psp: add PSP command

[Felix Held (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Name of user not set #1004133, Al Hirani, Avinash Alevoor, Rob Barnes, Fred Reitberger.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61462 )

Change subject: soc/amd/common/block/psp: add PSP command
......................................................................

Patch Set 8:

(3 comments)

File src/soc/amd/common/block/psp/psp_gen2.c:

https://review.coreboot.org/c/coreboot/+/61462/comment/276be1f6_df621313 
PS8, Line 125: u32 soc_read_c2p38(void)
since all bit combinations might be valid here, the return value can't be used for both success/error and register value returning. i'd use this implementation instead that doesn't have this possible problem https://review.coreboot.org/c/coreboot/+/60968/11/src/soc/amd/common/block/p...

https://review.coreboot.org/c/coreboot/+/61462/comment/9a138d8f_cadf8f39 
PS8, Line 147: 	if (soc_read_c2p38() & CORE_2_PSP_MSG_38_FUSE_SPL) {
this condition is also true in the error case of the soc_read_c2p38 call

https://review.coreboot.org/c/coreboot/+/61462/comment/bdd8d204_588c653e 
PS8, Line 152: 		printk(BIOS_DEBUG, "PSP: Fuse SPL not requested\n");
this needs to be put in curly brackets, since the code in the corresponding if statement is in curly brackets