Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33932 )
Change subject: mb/google/helios: Add ALC1011 in device tree to enable speaker amps
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33932/2/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/helios/gpio.c:
https://review.coreboot.org/c/coreboot/+/33932/2/src/mainboard/google/hatch/...
PS2, Line 91: PAD_NC
yes. thats right. […]
Wait. I was just looking at the schematics and it looks like this line is connected to RSTB on the amp. Shouldn't you be doing something like this here:
PAD_CFG_GPO(GPP_H13, 1, DEEP),
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33932
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0d71e3bd2d4493d059a33023c1afe1b630181d4f
Gerrit-Change-Number: 33932
Gerrit-PatchSet: 2
Gerrit-Owner: Sathya Prakash M R
sathya.prakash.m.r@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Naveen M
naveen.m@intel.com
Gerrit-Reviewer: Sathya Prakash M R
sathya.prakash.m.r@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 16 Jul 2019 05:59:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sathya Prakash M R
sathya.prakash.m.r@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment