Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/28702
Change subject: northbridge: Use 'unsigned int' to bare use of 'unsigned' ......................................................................
northbridge: Use 'unsigned int' to bare use of 'unsigned'
Change-Id: Ib70eb33fac654a773ea39a5fd4206435dffdabb7 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/amd/amdfam10/raminit_amdmct.c M src/northbridge/amd/lx/raminit.h M src/northbridge/intel/e7505/northbridge.c M src/northbridge/intel/e7505/raminit.h M src/northbridge/intel/fsp_rangeley/northbridge.c M src/northbridge/intel/fsp_sandybridge/gma.c M src/northbridge/intel/fsp_sandybridge/northbridge.c M src/northbridge/intel/gm45/gma.c M src/northbridge/intel/haswell/gma.c M src/northbridge/intel/haswell/minihd.c M src/northbridge/intel/haswell/northbridge.c M src/northbridge/intel/nehalem/gma.c M src/northbridge/intel/nehalem/northbridge.c M src/northbridge/intel/pineview/gma.c M src/northbridge/intel/pineview/raminit.c M src/northbridge/intel/sandybridge/gma.c M src/northbridge/intel/sandybridge/northbridge.c 17 files changed, 29 insertions(+), 22 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/28702/1
diff --git a/src/northbridge/amd/amdfam10/raminit_amdmct.c b/src/northbridge/amd/amdfam10/raminit_amdmct.c index ef54de5..2843b92 100644 --- a/src/northbridge/amd/amdfam10/raminit_amdmct.c +++ b/src/northbridge/amd/amdfam10/raminit_amdmct.c @@ -32,7 +32,7 @@
struct mem_controller; extern void activate_spd_rom(const struct mem_controller *ctrl); -extern int spd_read_byte(unsigned device, unsigned address); +extern int spd_read_byte(unsigned int device, unsigned int address);
void fam15h_switch_dct(uint32_t dev, uint8_t dct) { diff --git a/src/northbridge/amd/lx/raminit.h b/src/northbridge/amd/lx/raminit.h index 3a5d571..d106862 100644 --- a/src/northbridge/amd/lx/raminit.h +++ b/src/northbridge/amd/lx/raminit.h @@ -30,6 +30,6 @@ void sdram_initialize(int controllers, const struct mem_controller *ctrl);
/* mainboard specific */ -int spd_read_byte(unsigned device, unsigned address); +int spd_read_byte(unsigned int device, unsigned int address);
#endif diff --git a/src/northbridge/intel/e7505/northbridge.c b/src/northbridge/intel/e7505/northbridge.c index 6d351a3..b625a80 100644 --- a/src/northbridge/intel/e7505/northbridge.c +++ b/src/northbridge/intel/e7505/northbridge.c @@ -76,7 +76,7 @@ }
static void intel_set_subsystem(struct device *dev, - unsigned vendor, unsigned device) + unsigned int vendor, unsigned int device) { pci_write_config32(dev, PCI_SUBSYSTEM_VENDOR_ID, ((device & 0xffff) << 16) | (vendor & 0xffff)); diff --git a/src/northbridge/intel/e7505/raminit.h b/src/northbridge/intel/e7505/raminit.h index eae8935..1581b82 100644 --- a/src/northbridge/intel/e7505/raminit.h +++ b/src/northbridge/intel/e7505/raminit.h @@ -35,6 +35,6 @@
/* Mainboard exports this. */ -int spd_read_byte(unsigned device, unsigned address); +int spd_read_byte(unsigned int device, unsigned int address);
#endif /* RAMINIT_H */ diff --git a/src/northbridge/intel/fsp_rangeley/northbridge.c b/src/northbridge/intel/fsp_rangeley/northbridge.c index 27153f8..72b2761 100644 --- a/src/northbridge/intel/fsp_rangeley/northbridge.c +++ b/src/northbridge/intel/fsp_rangeley/northbridge.c @@ -173,7 +173,8 @@ pci_dev_set_resources(dev); }
-static void intel_set_subsystem(struct device *dev, unsigned vendor, unsigned device) +static void intel_set_subsystem(struct device *dev, unsigned int vendor, + unsigned int device) { if (!vendor || !device) { pci_write_config32(dev, PCI_SUBSYSTEM_VENDOR_ID, diff --git a/src/northbridge/intel/fsp_sandybridge/gma.c b/src/northbridge/intel/fsp_sandybridge/gma.c index 2cfd1f3..cba5869 100644 --- a/src/northbridge/intel/fsp_sandybridge/gma.c +++ b/src/northbridge/intel/fsp_sandybridge/gma.c @@ -66,8 +66,8 @@ gnvs_ptr->aslb = aslb; }
-static void gma_set_subsystem(struct device *dev, unsigned vendor, - unsigned device) +static void gma_set_subsystem(struct device *dev, unsigned int vendor, + unsigned int device) { if (!vendor || !device) { pci_write_config32(dev, PCI_SUBSYSTEM_VENDOR_ID, diff --git a/src/northbridge/intel/fsp_sandybridge/northbridge.c b/src/northbridge/intel/fsp_sandybridge/northbridge.c index b192161..111c201 100644 --- a/src/northbridge/intel/fsp_sandybridge/northbridge.c +++ b/src/northbridge/intel/fsp_sandybridge/northbridge.c @@ -248,8 +248,8 @@ } }
-static void intel_set_subsystem(struct device *dev, unsigned vendor, - unsigned device) +static void intel_set_subsystem(struct device *dev, unsigned int vendor, + unsigned int device) { if (!vendor || !device) { pci_write_config32(dev, PCI_SUBSYSTEM_VENDOR_ID, diff --git a/src/northbridge/intel/gm45/gma.c b/src/northbridge/intel/gm45/gma.c index 5335fbb..b86e2b3 100644 --- a/src/northbridge/intel/gm45/gma.c +++ b/src/northbridge/intel/gm45/gma.c @@ -788,7 +788,8 @@ intel_gma_restore_opregion(); }
-static void gma_set_subsystem(struct device *dev, unsigned vendor, unsigned device) +static void gma_set_subsystem(struct device *dev, unsigned int vendor, + unsigned int device) { if (!vendor || !device) { pci_write_config32(dev, PCI_SUBSYSTEM_VENDOR_ID, diff --git a/src/northbridge/intel/haswell/gma.c b/src/northbridge/intel/haswell/gma.c index 8f60da4..efc9fa3 100644 --- a/src/northbridge/intel/haswell/gma.c +++ b/src/northbridge/intel/haswell/gma.c @@ -494,8 +494,8 @@ intel_gma_restore_opregion(); }
-static void gma_set_subsystem(struct device *dev, unsigned vendor, - unsigned device) +static void gma_set_subsystem(struct device *dev, unsigned int vendor, + unsigned int device) { if (!vendor || !device) { pci_write_config32(dev, PCI_SUBSYSTEM_VENDOR_ID, diff --git a/src/northbridge/intel/haswell/minihd.c b/src/northbridge/intel/haswell/minihd.c index d8b4b66..52710bb 100644 --- a/src/northbridge/intel/haswell/minihd.c +++ b/src/northbridge/intel/haswell/minihd.c @@ -103,8 +103,8 @@ } }
-static void minihd_set_subsystem(struct device *dev, unsigned vendor, - unsigned device) +static void minihd_set_subsystem(struct device *dev, unsigned int vendor, + unsigned int device) { if (!vendor || !device) { pci_write_config32(dev, PCI_SUBSYSTEM_VENDOR_ID, diff --git a/src/northbridge/intel/haswell/northbridge.c b/src/northbridge/intel/haswell/northbridge.c index f61a478..0453246 100644 --- a/src/northbridge/intel/haswell/northbridge.c +++ b/src/northbridge/intel/haswell/northbridge.c @@ -408,8 +408,8 @@ mc_add_dram_resources(dev, &index); }
-static void intel_set_subsystem(struct device *dev, unsigned vendor, - unsigned device) +static void intel_set_subsystem(struct device *dev, unsigned int vendor, + unsigned int device) { if (!vendor || !device) { pci_write_config32(dev, PCI_SUBSYSTEM_VENDOR_ID, diff --git a/src/northbridge/intel/nehalem/gma.c b/src/northbridge/intel/nehalem/gma.c index 6e2d404..b89215d 100644 --- a/src/northbridge/intel/nehalem/gma.c +++ b/src/northbridge/intel/nehalem/gma.c @@ -623,7 +623,8 @@ intel_gma_restore_opregion(); }
-static void gma_set_subsystem(struct device *dev, unsigned vendor, unsigned device) +static void gma_set_subsystem(struct device *dev, unsigned int vendor, + unsigned int device) { if (!vendor || !device) { pci_write_config32(dev, PCI_SUBSYSTEM_VENDOR_ID, diff --git a/src/northbridge/intel/nehalem/northbridge.c b/src/northbridge/intel/nehalem/northbridge.c index 8f55e3c..4c6cdd4 100644 --- a/src/northbridge/intel/nehalem/northbridge.c +++ b/src/northbridge/intel/nehalem/northbridge.c @@ -191,7 +191,8 @@ pci_dev_set_resources(dev); }
-static void intel_set_subsystem(struct device *dev, unsigned vendor, unsigned device) +static void intel_set_subsystem(struct device *dev, unsigned int vendor, + unsigned int device) { if (!vendor || !device) { pci_write_config32(dev, PCI_SUBSYSTEM_VENDOR_ID, diff --git a/src/northbridge/intel/pineview/gma.c b/src/northbridge/intel/pineview/gma.c index 02100e9..eb67c65 100644 --- a/src/northbridge/intel/pineview/gma.c +++ b/src/northbridge/intel/pineview/gma.c @@ -304,7 +304,8 @@ intel_gma_restore_opregion(); }
-static void gma_set_subsystem(struct device *dev, unsigned vendor, unsigned device) +static void gma_set_subsystem(struct device *dev, unsigned int vendor, + unsigned int device) { if (!vendor || !device) { pci_write_config32(dev, PCI_SUBSYSTEM_VENDOR_ID, diff --git a/src/northbridge/intel/pineview/raminit.c b/src/northbridge/intel/pineview/raminit.c index a050e06..5adf865 100644 --- a/src/northbridge/intel/pineview/raminit.c +++ b/src/northbridge/intel/pineview/raminit.c @@ -102,7 +102,7 @@ __asm__ __volatile__("": : :"memory"); }
-static inline int spd_read_byte(unsigned device, unsigned address) +static inline int spd_read_byte(unsigned int device, unsigned int address) { return smbus_read_byte(device, address); } diff --git a/src/northbridge/intel/sandybridge/gma.c b/src/northbridge/intel/sandybridge/gma.c index 042c2a9..cd8f7b9 100644 --- a/src/northbridge/intel/sandybridge/gma.c +++ b/src/northbridge/intel/sandybridge/gma.c @@ -669,7 +669,8 @@ intel_gma_restore_opregion(); }
-static void gma_set_subsystem(struct device *dev, unsigned vendor, unsigned device) +static void gma_set_subsystem(struct device *dev, unsigned int vendor, + unsigned int device) { if (!vendor || !device) { pci_write_config32(dev, PCI_SUBSYSTEM_VENDOR_ID, diff --git a/src/northbridge/intel/sandybridge/northbridge.c b/src/northbridge/intel/sandybridge/northbridge.c index 7863810..cb0e5db 100644 --- a/src/northbridge/intel/sandybridge/northbridge.c +++ b/src/northbridge/intel/sandybridge/northbridge.c @@ -287,7 +287,8 @@ } }
-static void intel_set_subsystem(struct device *dev, unsigned vendor, unsigned device) +static void intel_set_subsystem(struct device *dev, unsigned int vendor, + unsigned int device) { if (!vendor || !device) { pci_write_config32(dev, PCI_SUBSYSTEM_VENDOR_ID,