Attention is currently required from: Subrata Banik.
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44815 )
Change subject: util/ifdtool: Identify chipset without platform name
......................................................................
Patch Set 5:
(2 comments)
File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/44815/comment/c0c7f954_258fd352
PS5, Line 62: "Unknown PCH",
What are these?
https://review.coreboot.org/c/coreboot/+/44815/comment/55bc1591_ae2e8345
PS5, Line 168: guess_ifd_2_chipset
Is this a good time to get rid of the ifd 1 vs 2 distinction? It was pretty arbitrary and there are other platforms in between (ifd 1.5 if you will).
It would be interesting to learn how Intel is doing the versioning / distinction here for their own tools
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44815
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I83763adb721e069343b19a10e503975ffa6abb24
Gerrit-Change-Number: 44815
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Wed, 12 May 2021 18:03:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment