Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37308 )
Change subject: soc/intel/cannonlake: Refactor pch_early_init() code ......................................................................
Patch Set 2:
(5 comments)
https://review.coreboot.org/c/coreboot/+/37308/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37308/2//COMMIT_MSG@11 PS2, Line 11: TCO Fits on the line above.
https://review.coreboot.org/c/coreboot/+/37308/2//COMMIT_MSG@11 PS2, Line 11: SMBUS SMBus
https://review.coreboot.org/c/coreboot/+/37308/2//COMMIT_MSG@14 PS2, Line 14: Renamed Rename
https://review.coreboot.org/c/coreboot/+/37308/2/src/soc/intel/cannonlake/ro... File src/soc/intel/cannonlake/romstage/pch.c:
https://review.coreboot.org/c/coreboot/+/37308/2/src/soc/intel/cannonlake/ro... PS2, Line 22: Programming Program
https://review.coreboot.org/c/coreboot/+/37308/2/src/soc/intel/cannonlake/ro... PS2, Line 25: Enable enable