[coreboot-gerrit] Change in ...coreboot[master]: google/kukui: Implement HW reset function

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31118 )

Change subject: google/kukui: Implement HW reset function
......................................................................

google/kukui: Implement HW reset function

Asserting GPIO PERIPHERAL_EN8 will send a signal to EC to trigger a HW
reset for SoC and H1.

BUG=b:80501386
BRANCH=none
TEST=emerge-kukui coreboot; manually verified the do_board_reset() on
     Kukui P1

Change-Id: I9afad84af2031a766bc08fc76c8b5f55588c453a
Signed-off-by: Tristan Shieh 
Reviewed-on: https://review.coreboot.org/c/31118
Reviewed-by: Paul Menzel 
Reviewed-by: Julius Werner 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/google/kukui/Kconfig
M src/mainboard/google/kukui/Makefile.inc
M src/mainboard/google/kukui/gpio.h
A src/mainboard/google/kukui/reset.c
4 files changed, 29 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Julius Werner: Looks good to me, approved

diff --git a/src/mainboard/google/kukui/Kconfig b/src/mainboard/google/kukui/Kconfig
index 902fa38..7635e5f 100644
--- a/src/mainboard/google/kukui/Kconfig
+++ b/src/mainboard/google/kukui/Kconfig
@@ -37,7 +37,6 @@
    select EC_GOOGLE_CHROMEEC_SPI
    select MAINBOARD_HAS_SPI_TPM_CR50 if VBOOT
    select MAINBOARD_HAS_TPM2 if VBOOT
-	select MISSING_BOARD_RESET

config MAINBOARD_DIR
    string
diff --git a/src/mainboard/google/kukui/Makefile.inc b/src/mainboard/google/kukui/Makefile.inc
index acd2c45..9f8c313 100644
--- a/src/mainboard/google/kukui/Makefile.inc
+++ b/src/mainboard/google/kukui/Makefile.inc
@@ -4,15 +4,18 @@
 bootblock-y += bootblock.c
 bootblock-y += chromeos.c
 bootblock-y += memlayout.ld
+bootblock-y += reset.c
 decompressor-y += memlayout.ld

verstage-y += chromeos.c
+verstage-y += reset.c
 verstage-y += verstage.c
 verstage-y += memlayout.ld

romstage-y += boardid.c
 romstage-y += chromeos.c
 romstage-y += memlayout.ld
+romstage-y += reset.c
 romstage-y += romstage.c
 romstage-y += sdram_configs.c

@@ -20,3 +23,4 @@
 ramstage-y += chromeos.c
 ramstage-y += mainboard.c
 ramstage-y += memlayout.ld
+ramstage-y += reset.c
diff --git a/src/mainboard/google/kukui/gpio.h b/src/mainboard/google/kukui/gpio.h
index 20a50a6..024b0d7 100644
--- a/src/mainboard/google/kukui/gpio.h
+++ b/src/mainboard/google/kukui/gpio.h
@@ -21,6 +21,7 @@
 #define EC_IRQ		GPIO(PERIPHERAL_EN1)
 #define EC_IN_RW	GPIO(PERIPHERAL_EN14)
 #define CR50_IRQ	GPIO(PERIPHERAL_EN3)
+#define GPIO_RESET	GPIO(PERIPHERAL_EN8)

void setup_chromeos_gpios(void);

diff --git a/src/mainboard/google/kukui/reset.c b/src/mainboard/google/kukui/reset.c
new file mode 100644
index 0000000..609ecb4
--- /dev/null
+++ b/src/mainboard/google/kukui/reset.c
@@ -0,0 +1,24 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright 2019 MediaTek Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <gpio.h>
+#include <reset.h>
+
+#include "gpio.h"
+
+void do_board_reset(void)
+{
+	gpio_output(GPIO_RESET, 1);
+}