John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40425 )
Change subject: mb/google/volteer: Add support for USB Type-C ports ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40425/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/acpi/usbc.asl:
PS1:
BTW, for the specific case of Volteer: both the parade part and burnside bridge have similar expecte […]
Maybe "chip drivers/intel/pmc"?
https://review.coreboot.org/c/coreboot/+/40425/1/src/mainboard/google/voltee... PS1, Line 24: "normal"
Is this the terminology being used by the kernel code which will be upstreamed? […]
Heikki's comment: "Those names are now reserved for generic references that point to the actual usb3 and usb2 ports. Here we supply the port indexes that the mux-agent driver needs to use when communicating with the PMC".
There will be minor update for ports properties: usb2-port -> usb2-port-number usb3-port -> usb3-port-number