Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37178 )
Change subject: soc/amd/common/block/acpimmio: fix ACPIMMIO decode enable function
......................................................................
Patch Set 5: Code-Review-2
(1 comment)
https://review.coreboot.org/c/coreboot/+/37178/5/src/soc/amd/common/block/in...
File src/soc/amd/common/block/include/amdblocks/acpimmio_map.h:
https://review.coreboot.org/c/coreboot/+/37178/5/src/soc/amd/common/block/in...
PS5, Line 26: * enable the decode in PMx24 instead. All discrete FCHs and the Kabini
Doesn't the comment here specifically say fam14-15tn-16kn do not use ACPIMMIO_DECODE_REGISTER 0x4 and the bits specified below?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37178
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaa31abc3dbdf77d8513fa83c7415b9a1b7fd266f
Gerrit-Change-Number: 37178
Gerrit-PatchSet: 5
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 01 Dec 2019 19:08:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment